Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTL in "See corresponding records" is wrong #25

Closed
mathieumd opened this issue Feb 8, 2024 · 3 comments
Closed

TTL in "See corresponding records" is wrong #25

mathieumd opened this issue Feb 8, 2024 · 3 comments

Comments

@mathieumd
Copy link

An A RR created from happyDomain is showing:

test A 1.2.3.4

Class IN
TTL 3600
RRType A (0x1)
A 1.2.3.4

However, it's actual TTL after being created into PowerDNS, is 86400:

test.example.com 86400 IN A 1.2.3.4

PS: BTW, the <div> shown when clicking the button "See corresponding records" should not have a max-height: 120px;", IMHO!
Should not max-height=120px

PPS: (Sorry!) When trying to increase the TTL value from 0 to, by example, 7200, I get an error popup:

Something is wrong in received data: json: cannot unmarshal string into Go struct field ServiceMeta._ttl of type uint32

@nemunaire
Copy link
Member

I ack the whole issue. Thanks for your review!

What behavior did you expect instead of max-height: 120px;?

@mathieumd
Copy link
Author

What behavior did you expect instead of max-height: 120px;?

Simply removing it makes contents visible, while leaving it displays scrollbars both at right and bottom, which crops the contents.

But if you need to set a max-height, maybe it'll be better to use em instead of px?

nemunaire added a commit that referenced this issue May 21, 2024
@nemunaire
Copy link
Member

As a Service, in the meaning of happyDomain, could regroup many records, we need to cap the maximum size to something that keep the modal usable. I don't know if the expanded/explained mode is really useful, perhaps it should be better to include the TTL in the raw line, when it's not the default zone TTL (as we could expect in a zone file).

Regarding the size, this region is now resizable, keeping the default to 120px.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants