-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TTL in "See corresponding records" is wrong #25
Comments
I ack the whole issue. Thanks for your review! What behavior did you expect instead of |
Simply removing it makes contents visible, while leaving it displays scrollbars both at right and bottom, which crops the contents. But if you need to set a max-height, maybe it'll be better to use |
As a Service, in the meaning of happyDomain, could regroup many records, we need to cap the maximum size to something that keep the modal usable. I don't know if the expanded/explained mode is really useful, perhaps it should be better to include the TTL in the raw line, when it's not the default zone TTL (as we could expect in a zone file). Regarding the size, this region is now resizable, keeping the default to 120px. |
An
A
RR created from happyDomain is showing:However, it's actual TTL after being created into PowerDNS, is 86400:
PS: BTW, the
![Should not max-height=120px](https://private-user-images.githubusercontent.com/2104679/303291727-beb691fa-5b0d-452e-95b1-6b94ddc82659.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk0Mjg2MDYsIm5iZiI6MTcxOTQyODMwNiwicGF0aCI6Ii8yMTA0Njc5LzMwMzI5MTcyNy1iZWI2OTFmYS01YjBkLTQ1MmUtOTViMS02Yjk0ZGRjODI2NTkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYyNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MjZUMTg1ODI2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MmE0YzdjZDM4MjljM2JlMzM1ZWRmYzc3ODJiNmY3M2JiNDMwYzRkNjA3M2RhZmU0YTUzMjczZmIzYTg0ZjljMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.xVzIiA2yDzfzNWpBtSaY5aOkoro__4g1wJ2WmwPn4fM)
<div>
shown when clicking the button "See corresponding records" should not have amax-height: 120px;"
, IMHO!PPS: (Sorry!) When trying to increase the TTL value from 0 to, by example, 7200, I get an error popup:
The text was updated successfully, but these errors were encountered: