Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression in NTSC --WibbleRemover #422

Closed
Gamnn opened this issue Jan 21, 2020 · 0 comments
Closed

regression in NTSC --WibbleRemover #422

Gamnn opened this issue Jan 21, 2020 · 0 comments

Comments

@Gamnn
Copy link
Contributor

Gamnn commented Jan 21, 2020

d26b826 seemed to break NTSC WibbleRemover.

Traceback (most recent call last):
  File "/home/gamn/github/ld-decode/ld-decode", line 78, in <module>
    ldd = LDdecode(filename, outname, loader, analog_audio = 0 if args.daa else 44.100, digital_audio = not args.noefm, system=system, doDOD = not args.nodod, threads=args.threads, extra_options=extra_options)
  File "/home/gamn/github/ld-decode/lddecode/core.py", line 2533, in __init__
    self.rf = RFDecode(system=system, decode_analog_audio=analog_audio, decode_digital_audio=digital_audio, has_analog_audio = self.has_analog_audio, extra_options = extra_options)
  File "/home/gamn/github/ld-decode/lddecode/core.py", line 338, in __init__
    self.computefilters()
  File "/home/gamn/github/ld-decode/lddecode/core.py", line 346, in computefilters
    self.computevideofilters()
  File "/home/gamn/github/ld-decode/lddecode/core.py", line 444, in computevideofilters
    video_notch = sps.butter(3, [DP['video_lpf_freq']/self.freq_half, 5.0/self.freq_half], 'bandstop')
  File "/home/gamn/.local/lib/python3.6/site-packages/scipy/signal/filter_design.py", line 2858, in butter
    output=output, ftype='butter', fs=fs)
  File "/home/gamn/.local/lib/python3.6/site-packages/scipy/signal/filter_design.py", line 2341, in iirfilter
    raise ValueError("Digital filter critical frequencies "
ValueError: Digital filter critical frequencies must be 0 < Wn < 1

happycube added a commit that referenced this issue Jan 22, 2020
@Gamnn Gamnn closed this as completed Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant