Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ld-discmap sets numberOfSequentialFields to -1 #463

Closed
Gamnn opened this issue Feb 13, 2020 · 1 comment
Closed

ld-discmap sets numberOfSequentialFields to -1 #463

Gamnn opened this issue Feb 13, 2020 · 1 comment
Labels
bug ld-decode-tools An issue only affecting the ld-decode-tools

Comments

@Gamnn
Copy link
Contributor

Gamnn commented Feb 13, 2020

ld-discmap outputs numberOfSequentialFields as -1.
This breaks ld-export-metadata, and could possibly affect other tools.

Before ld-discmap:

{
  "numberOfSequentialFields": 10,
  "isSourcePal": false,
  "fsc": 3579545,
  "fieldWidth": 910,
  "sampleRate": 14318180,
  "black16bIre": 15360,
  "white16bIre": 51200,
  "fieldHeight": 263,
  "colourBurstStart": 74,
  "colourBurstEnd": 110,
  "activeVideoStart": 134,
  "activeVideoEnd": 894
}

After:

{
  "activeVideoEnd": 894,
  "activeVideoStart": 134,
  "black16bIre": 15360,
  "colourBurstEnd": 110,
  "colourBurstStart": 74,
  "fieldHeight": 263,
  "fieldWidth": 910,
  "fsc": 3579545,
  "isMapped": true,
  "isSourcePal": false,
  "numberOfSequentialFields": -1,
  "sampleRate": 14318180,
  "white16bIre": 51200
}

Tested on NTSC CAV and CLV.

@simoninns simoninns added bug ld-decode-tools An issue only affecting the ld-decode-tools labels Feb 13, 2020
simoninns pushed a commit that referenced this issue Feb 16, 2020
@simoninns
Copy link
Collaborator

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ld-decode-tools An issue only affecting the ld-decode-tools
Projects
None yet
Development

No branches or pull requests

2 participants