Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hsync dropout causes AGC blip #503

Closed
Gamnn opened this issue Jun 15, 2020 · 3 comments
Closed

hsync dropout causes AGC blip #503

Gamnn opened this issue Jun 15, 2020 · 3 comments

Comments

@Gamnn
Copy link
Contributor

Gamnn commented Jun 15, 2020

Similar to #493, if there's an issue in the wrong spot, the AGC can get the brightness wrong in a frame. I am thinking AGC should be more temporally aware by default.

frame_ntsc_source_6

agc_blip.ldf.zip
@Gamnn
Copy link
Contributor Author

Gamnn commented Jun 15, 2020

Another example.

agc_blip2.ldf.zip

happycube added a commit that referenced this issue Jun 21, 2020
@happycube
Issue #503 - use median instad of mean for line level comp
9c91c09
happycube added a commit that referenced this issue Jun 21, 2020
@happycube
Merge pull request #504 from happycube/issue503
88d6f68 
Issue #503 - use median instad of mean for line level comp
@happycube
Copy link
Owner

happycube commented Jun 21, 2020 •
edited
Loading

I put in a very simple fix - using medians instead of means for each line, which should help. I could do a bit more on this if needed though, so please test and close only if you think this fixes it enough.

@happycube
Copy link
Owner

Now uses regular HSYNCs to compute sync/IRE0 AGC, so this should be much more robust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@happycube @Gamnn