Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ld-dropout-correct broken since ld-analyse changes... #709

Closed
happycube opened this issue Mar 18, 2022 · 2 comments
Closed

ld-dropout-correct broken since ld-analyse changes... #709

happycube opened this issue Mar 18, 2022 · 2 comments
Labels
ld-decode-tools An issue only affecting the ld-decode-tools

Comments

@happycube
Copy link
Owner

Exact same cause as #707 , applying the same code to ld-dropout-correct. In this case the dropout corrector doesn't, since it thinks the active range is from lines 0 to 0.
@happycube happycube added the ld-decode-tools An issue only affecting the ld-decode-tools label Mar 18, 2022
@happycube
Copy link
Owner Author

I think a better fix would be to apply the line parameters as part of the constructor, but I'm too lazy to do that right now...

@happycube
Copy link
Owner Author

Looking a bit more, I think the stacker could also have broken, so I fixed it in the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ld-decode-tools An issue only affecting the ld-decode-tools
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@happycube