Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chroma Decoding broken in ld-analyse #707

Closed
IanSmallshire opened this issue Feb 28, 2022 · 6 comments
Closed

Chroma Decoding broken in ld-analyse #707

IanSmallshire opened this issue Feb 28, 2022 · 6 comments

Comments

@IanSmallshire
Copy link
Collaborator

IanSmallshire commented Feb 28, 2022 •
edited

Using commit f40b683 ( Feb 7, 2022) the colour is available in ld-analyse
Using the latest commit 7e6eac5 (Feb 25, 2022) the image is black when viewing chroma.

Old Commit
image
image

New version (showing chroma)
image
@IanSmallshire IanSmallshire changed the title Chroma Decoding broken in ld-analyuse Chroma Decoding broken in ld-analyse Feb 28, 2022
@IanSmallshire
Copy link
Collaborator Author

Have checked it was broken on this commit 08f32a5

@IanSmallshire
Copy link
Collaborator Author

Nothing showing up with starting ld-analyse -d for the debug options..
image

@atsampson
Copy link
Collaborator

@MooglyGuy, would you mind having a look at this? Probably missing initialisation in ld-analyse for your padding change - if you can't figure out what's wrong let me know and I'll have a look later.

@MooglyGuy
Copy link

Absolutely, I'll have a look at it this evening. I do apologize for the delay, work and life have been chaos.

@atsampson
Copy link
Collaborator

Don't worry, I know the feeling!

MooglyGuy pushed a commit to MooglyGuy/ld-decode that referenced this issue Mar 1, 2022
Fixed issue happycube#707
72b7f56
happycube added a commit that referenced this issue Mar 1, 2022
@happycube
Merge pull request #708 from MooglyGuy/master
b8da277 
Fixed issue #707
@IanSmallshire
Copy link
Collaborator Author

Confirmed fix, Cheers

happycube added a commit that referenced this issue Mar 18, 2022
@happycube
Apply fix from #707 to ld-dropout-correct
d2c8fde
@happycube happycube mentioned this issue Mar 18, 2022
Closed
happycube added a commit that referenced this issue Mar 18, 2022
@happycube
fix #707/709 in the library itself
cda86e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@atsampson @MooglyGuy @IanSmallshire