Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ld-disc-stacker crash issue #781

Closed
vrunk11 opened this issue Aug 26, 2022 · 3 comments
Closed

ld-disc-stacker crash issue #781

vrunk11 opened this issue Aug 26, 2022 · 3 comments
Labels
ld-decode uncategorized crash report End-user crash report awaiting categorization

Comments

@vrunk11
Copy link
Contributor

vrunk11 commented Aug 26, 2022

So I have 3 discs but 1 of them have a big scratch that keep the player skipping back so I made 2 sample for capturing the whole disc

when I try to stack the disc, it read the smaller sample (the part 1 on the scratched disc) with a wrong length
and when it reaches the end of the sample it crash

here is the link with the 3 tbc files where I can reproduce the crash (using a Windows build) :
https://drive.google.com/file/d/1NK10nCDHgFBhN6rso7621Uo2N7TNwQcr/view?usp=sharing

@simoninns
Copy link
Collaborator

A couple of things - you have linked TBC files - recreation of the error (since there is no indication of where in the tool chain the JSON gets corrupted) requires end-to-end. Therefore you need to supply laserdisc samples (as the JSON is created by ld-decode, so any bugs there will already be in the TBC files).

Also it would be useful if you could include the steps to recreate. From the LDS until the error occurs - what commands did you use (on the linked LDS files) to make the problem appear.

Also state any environmental things (which OS version and build, etc.)

@simoninns simoninns added the ld-decode uncategorized crash report End-user crash report awaiting categorization label Aug 27, 2022
@vrunk11
Copy link
Contributor Author

vrunk11 commented Aug 28, 2022

here is an ldf cuted with the part that cause issue https://drive.google.com/file/d/1uOlufL4f8HilODcnzgCvS8U_8ab8qEnP/view?usp=sharing
i decoded using NTSC option ld-decode then -> process-vbi ->disc-map -> disc-stacker
(on Windows 10)

(the ldf should be used with the 2 other tbc for test the stacking)

simoninns added a commit that referenced this issue Aug 28, 2022
happycube added a commit that referenced this issue Aug 28, 2022
Fix for issue #781 - Edge-case caused out of bounds sequential frame …
@simoninns
Copy link
Collaborator

FIxed in latest PR to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ld-decode uncategorized crash report End-user crash report awaiting categorization
Projects
None yet
Development

No branches or pull requests

2 participants