-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ld-disc-stacker crash issue #781
Comments
A couple of things - you have linked TBC files - recreation of the error (since there is no indication of where in the tool chain the JSON gets corrupted) requires end-to-end. Therefore you need to supply laserdisc samples (as the JSON is created by ld-decode, so any bugs there will already be in the TBC files). Also it would be useful if you could include the steps to recreate. From the LDS until the error occurs - what commands did you use (on the linked LDS files) to make the problem appear. Also state any environmental things (which OS version and build, etc.) |
here is an ldf cuted with the part that cause issue https://drive.google.com/file/d/1uOlufL4f8HilODcnzgCvS8U_8ab8qEnP/view?usp=sharing (the ldf should be used with the 2 other tbc for test the stacking) |
Fix for issue #781 - Edge-case caused out of bounds sequential frame …
FIxed in latest PR to master |
So I have 3 discs but 1 of them have a big scratch that keep the player skipping back so I made 2 sample for capturing the whole disc
when I try to stack the disc, it read the smaller sample (the part 1 on the scratched disc) with a wrong length
and when it reaches the end of the sample it crash
here is the link with the 3 tbc files where I can reproduce the crash (using a Windows build) :
https://drive.google.com/file/d/1NK10nCDHgFBhN6rso7621Uo2N7TNwQcr/view?usp=sharing
The text was updated successfully, but these errors were encountered: