Add unit tests for VbiDecoder #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, a field containing only lead-out codes shouldn't be reported as either CAV or CLV.
This includes some tests (#if 0-d out) that don't currently pass.
A copy-and-paste error meant that parity wasn't being checked correctly for two of the X5 bits.
This means that all the VBI codes that use BCD now check whether all the digits are valid.
atsampson
added
enhancement
ld-decode-tools
|
Gave the code a quick browse through; changes look like a nice improvement in readability and the like, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests for VbiDecoder (which are now run by the CI), and fix some minor problems they revealed:
I've added tests for several of the oddities we've seen on real discs, but if anyone's got any more it'd be easy enough to add them.