crack at #462 #464
Merged
crack at #462 #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a bit hack-y. I think changing line 73 in core.py to and line 93 to might be the proper solution, but I've not had time to test. |
|
The timings should be according to the NTSC specifications as-is? Either way, I'd advise a complete regression test of all tools for NTSC before this is merged as the timings are used by pretty much everything in the processing chain. |
|
In other words @Gamnn - did you test this change across all tools in your branch before requesting a merge? |
|
I've tested the hacky-solution that only modifies the json output, but not the change to activeVideoUS, which I haven't committed yet, pending input from @happycube. |
This seems to work, and is more elegant than the previous attempt.
|
activeVideoUS adjustment tested and committed. Seems good on what I've tested so far. |
happycube
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output NTSC activeVideoEnd as 760 from activeVideoStart, if it doesn't exceed fieldWidth. There's probably a more elegant way to do this.