getVideoField: when seeking forward isn't possible, try reading and discarding #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When SourceVideo::getVideoField is reading video from an unseekable source, like a pipe, trying to seek forward to a field later in the file would fail -- which, for example, means you couldn't use "ld-chroma-decoder -s" when input was from a pipe. Make it try to read and discard data instead when seeking forward fails. If reading fails or hits the end of the input stream, it'll report an error as before.
atsampson
added
enhancement
ld-decode-tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SourceVideo::getVideoField is reading video from an unseekable source, like a pipe, trying to seek forward to a field later in the file would fail -- which, for example, means you couldn't use "ld-chroma-decoder -s" when input was from a pipe.
Make it try to read and discard data instead when seeking forward fails. If reading fails or hits the end of the input stream, it'll report an error as before.