Use the 3D rather than 2D result in ntsc3d #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the removal of the OpenCV code in 6c7f74d663d ("Fix for
issue happycube#484"), ntsc3d always chooses the 2D result, so it behaves the
same as ntsc2d. This makes it always use the 3D result instead, which
produces artefacts on motion, but much better quality than ntsc2d for
still images.
atsampson
added
enhancement
ld-decode-tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the removal of the OpenCV code in #484, ntsc3d always chooses the 2D result, so it behaves the same as ntsc2d. This makes it always use the 3D result instead, which produces artefacts on motion, but much better quality than ntsc2d for still images - so it is actually useful for stills even without the motion detection.
As an example, here's frames 1921-1923 of PILA-1501 with ntsc2d (and current ntsc3d):
And here they are with ntsc3d after this change - the second frame is awful, but the other two are much better: