Add BT.601 YCbCr output #618
Conversation
There was a problem hiding this comment.
Thanks for this - the overall approach looks good, and it's nice to see references for the maths!
I've added a few review comments - most of these are minor stylistic things, but you can also simplify how the Configuration stuff works (by making MonoDecoder work like the PAL/NTSC decoders).
|
Incidentally - have you tried my testsuite for ld-chroma-decoder with your changes? If you clone this repo, the try-chroma-decoder script has a fairly extensive set of tests, many of which can work using the files in ld-decode-testdata; it should produce the same output before your changes and after. |
|
@atsampson Do you want changes as a separate patch or squashed into this one? If I |
ifb
force-pushed
the
add-ycbcr
branch
6 times, most recently
from
8499614
to
71bfb27
Compare
I cloned it a long time ago, but never used it since I didn't have any of the test LD files. I recently downloaded GGV1011 so I'd have something that's PAL, so |
There was a problem hiding this comment.
This all looks good to me now - thank you very much!
I've just run my testsuite over it and it produces bitwise identical output to master for all the existing tests (so I guess I'll have to write some YCbCr tests now...).
I'd suggest squashing the revisions into your original changes in this case - it doesn't make much difference here but it makes the history a bit tidier if anyone needs to do a bisection in the future.
ifb
force-pushed
the
add-ycbcr
branch
2 times, most recently
from
b621c16
to
e8b24d9
Compare
ld-chroma-decoder: add the -p/--output-format option to select between 'rgb' and 'yuv' output formats. 'rgb' is the default and always outputs 16-bit packed RGB48 data. 'yuv' outputs 16-bit planar YUV444P16, unless the mono chroma decoder is used and then 16-bit GRAY16 is output instead. Note that YCbCr is often mistakenly refered to as YUV, a convention we continue here.
Add planar YCbCr output (YUV444P16 or GRAY16).