Build cleanly with Qt 5.15 (and other minor fixes) #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atsampson
added
ld-decode-tools
The first one produced a warning from uic because it had a duplicate ID, but neither is actually needed.
The OpenCV code was removed in 6c7f74d663d ("Fix for issue happycube#484").
This catches up on the changes for noise reduction and YCbCr output.
sprintf is deprecated in Qt 5.15.
The latter is deprecated in Qt 5.15, and the only difference is that it doesn't force a flush (which probably isn't what we want in the middle of printing a dropout list anyway).
|
Reviewed by committee on IRC :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit messages for more details. The general aim here was to get rid of the warnings when building ld-decode against Qt 5.15, but I found a few other trivial things in the process.
One warning remains, about
QLabel::pixmap()being deprecated, but I can't fix that without adding a version conditional for older Qt and I don't think it's worth it.