Clear Comb::FrameBuffer::clpbuffer before each frame #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gamn reported that ntsc2d was producing differences in output for
identical input after 200+ frames. Bisection narrowed this down to
4f06cb5956c9 ("Use QScopedPointer for current/previousFrameBuffer.").
The problem was that the Comb code didn't explicitly initialise
clpbuffer. The code fills in values for the active region, but it
assumes anything outside the active region will read as 0 when
filtering -- this was probably the case by accident before when
clpbuffer was allocated each time by Qt.
Zeroing the buffer explicitly fixes it.
|
Seems to be working for me. |
|
Excellent, cheers. I'll merge this one then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Gamnn reported that ntsc2d was producing differences in output for identical input after 200+ frames. Bisection narrowed this down to ff5f991.
The problem was that the
Combcode didn't explicitly initialiseclpbuffer. The code fills in values for the active region, but itassumes anything outside the active region will read as 0 when filtering -- this was probably the case by accident before when
clpbufferwas allocated each time by Qt.Zeroing the buffer explicitly fixes it.
Fixes #623. @Gamnn, please can you check this works for your file now?