Update ld-ldf-reader for ffmpeg 4.5 #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was based on an example that used the old avcodec_decode_audio4 API, which will be removed in ffmpeg 4.5. The changes here just update it to match the latest version of the example, which uses avcodec_receive_frame instead, with the seeking changes re-added. The av_register_all function will also be removed in 4.5, but it's still necessary to call it in older versions of ffmpeg to get the codecs registered, so I've added a version conditional around it. I've tested this with ffmpeg 3.4 (as in Ubuntu 18.04) and 4.5 in development (current master).
happycube
approved these changes
May 2, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was based on an example that used the old
avcodec_decode_audio4API, which will be removed in ffmpeg 4.5. The changes here just update it to match the latest version of the example, which usesavcodec_receive_frameinstead, with the seeking changes re-added.The
av_register_allfunction will also be removed in 4.5, but it's still necessary to call it in older versions of ffmpeg to get the codecs registered, so I've added a version conditional around it.I've tested this with ffmpeg 3.4 (as in Ubuntu 18.04) and 4.5 in development (current master).