Add LineNumber and rework how line numbers are shown in the scope #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atsampson
added
enhancement
ld-decode-tools
We can use these names directly when reading and writing JSON, and in GetVideoSystemDescription -- there's no need to duplicate the list of systems anywhere. Add a function for parsing system names, since the JSON parser and ld-chroma-encoder both need to do this.
This represents a line number within a particular video system, and can convert to and from standard numbering and the four different formats ld-decode uses internally.
It's always given lastScope* as its arguments, so we may as well remove the arguments and have it use those variables directly.
Previously we showed a 1-based line number within the frame, which is only meaningful internally to ld-analyse. We now use spin boxes to show 0-based X and Y coordinates within the full frame (as you'd see in an image editor), and labels to show the system, standard line number, field, and 1-based line within the field (as used in the field metadata).
|
Added a function to parse VideoSystem names, since #752 wanted to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LineNumber class represents a line number within a ComponentFrame/OutputFrame, and can convert between the various different representations of line numbers that the ld-decode tools use - plus the standard way of numbering PAL/NTSC lines. There are various places in the code that could potentially use this in the future, but for now...
The oscilloscope view has been converted to use LineNumber, so it now shows the selected X/Y coordinates within the frame, and the line numbers that you need if you're referring to a standard or working with the metadata:
Thanks to various people on IRC/Discord for workshopping the UI changes!