chroma-encoder: Fix phase error in wideband-yuv mode #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NTSC .tbc files use IQ sampling per SMPTE 244M. Encode Y'UV and convert to Y'IQ, except do it correctly this time. It was about 5 degrees off before.
|
All looks good now: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NTSC .tbc files use IQ sampling per SMPTE 244M. Encode Y'UV and convert to Y'IQ, except do it correctly this time. It was about 5 degrees off before.
I had this correct locally at some point, but I managed to break it before making #752 I don't like replacing magic numbers with more magic numbers, but shifting 57 degrees does make sense (zeroH is 57/90 between samples).
The new vectorscope makes it much easier to verify correctness, too.