Add Video Parameters dialogue to ld-analyse #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The other windows mostly have shortcuts, so this should have one too. (You can close any of the QDialogs by pressing escape, so there's no need to make it toggle.)
This avoids duplicating the code to update the main view and the scopes.
Fix a couple of typos in related comments too.
Previously they had minimum and maximum sizes set to achieve the same effect -- this makes Qt work out the size automatically. The VBI dialog now uses grid layouts -- previously it was laid out with absolute positions for most of the widgets.
You can also set the black/white levels by shift-clicking on the scope.
Rework the aspect ratio button in the main window so it now just toggles between the source and display aspect ratios.
startBackgroundLoad now returns a bool to indicate explicitly whether it succeeded.
atsampson
added
enhancement
ld-decode-tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets you edit the black/white levels and aspect ratio in ld-analyse, then save them back to the JSON file. You can also set the black/white levels by shift-clicking on the oscilloscope. For NTSC sources, there are buttons to set the black level for both NTSC and NTSC-J (see #744). The aspect ratio button now just toggles SAR/DAR.
When saving, I've made it rename the existing .json to .json.bup if it doesn't already exist, as ld-process-vbi does. I think I've done this in a way that'll work on non-Unixy filesystems.
There's a fair amount of GUI refactoring in here to support this, so apologies if I've broken anything else in the process... It'll need some updates to the manual, but I haven't (non-trivially) changed the appearance of anything that already existed so it should only need a screenshot of the new dialogue.