Optimize downscale including using numba #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should be downscale_audio, haven't touced downscale |
|
I think it's intentional so that dropouts could be assigned to one of the boundaries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informal test using timeit indicates it's like 100x faster (doing loops in python directly is VERY inefficient). It was one of the functions identified via the profiler.
Should give a small speedup on samples with analog audio.
was a little unsure about what some of the arrays represent so the function docs needs looking over
Also, noted that the 16-bit PCM values are limited to +/- 32766 rather than the typical -32,768 to 32,767, wasn't sure if this is intentional and maybe required by the format or if it's an oversight.