Remove unused data from demodblock output, remove likely unneeded rawdata copy #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
demod_hpf isn't used for anything currently (looks like it was intended to be used for DOD at some point, but the code is commented out. As the output from demodblock is pickled for sending between threads, not calculating and storing this unneeded array should cut down on memory bandwidth and processing a tad. demod_hpf could be added back later if needed.
Also removed the extra clone of rawdata
I didn't touch it for now, but demod_raw in the output data block is also just used to check where values exceed a threshold in dropout_detect_demod, so demodblock output could possibly be further slimmed by doing that calculation in demodblock instead and output the boolean array result of that instead of a array of doubles as it is now.
Some quick testing does indicate there is some notable speedup from these changes