Don't write invalid JSON when no valid burst is found #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, Python will encode NaN as "NaN" in JSON output, but this isn't permitted by the JSON standard. A NaN being present in the output indicates that something has gone wrong anyway (and the tools won't know what to do with it), so it's better to blow up here rather than writing unparseable output.
atsampson
added
bug
ld-decode
happycube
approved these changes
Oct 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the SFTP, in
adamsampson/Faults/issue809, there's the first few frames of Easy Rider (LD10005) side 2.Decoding this causes
FieldPAL.calc_burstmedianto return NaN. This appears to be because the disc's mastered a bit hot - in the first field, all the lines trip the test for excessive burst amplitude inget_burstlevel.The NaN eventually gets written to
burstMedianIrein the JSON file... but Python'sjson.dumpwrites it asNaN, which isn't permitted by the JSON spec.These two commits pass
allow_nan=Falsetojson.dump, and fix the test incalc_burstmedianso it returns 0 when no burst is found. It might be worth looking at theget_burstlevelheuristic to see if there's a better way of handling discs like this, though?