Add more tests for Attributes.

happygiraffe · Oct 21, 2005 · 1420858 · 1420858
1 parent 796455d
commit 1420858
Show file tree

Hide file tree

Showing 2 changed files with 74 additions and 0 deletions.
diff --git a/lib/XML/Filter/Normalize.pm b/lib/XML/Filter/Normalize.pm
@@ -110,6 +110,12 @@ sub correct_element_data {
         if ( !$v->{ Prefix } && $v->{ Name } && $v->{ Name } =~ m/:/ ) {
             $v->{ Prefix } = ( split /:/, $v->{ Name }, 2 )[0];
         }
+        elsif ( !$v->{ NamespaceURI } && $v->{ Prefix } ) {
+            $v->{ NamespaceURI } = $nsup->get_uri( $v->{ Prefix } );
+        }
+        elsif ( !$v->{ Name } && $v->{ Prefix } && $v->{ LocalName } ) {
+            $v->{ Name } = $v->{ Prefix } . ':' . $v->{ LocalName };
+        }
     }
 
     return $data;

diff --git a/t/xml-filter-normalize.t b/t/xml-filter-normalize.t
@@ -207,6 +207,74 @@ my @test_data = (
             Prefix       => 'foo',
         },
     },
+    #----------------------------------------
+    {
+        desc => 'corrects missing NamespaceURI in Attribute',
+        ns   => [ [ foo => $TEST_NS ] ],
+        in   => {
+            Attributes => {
+                "{$TEST_NS}baz" => {
+                    LocalName    => 'baz',
+                    Name         => 'foo:baz',
+                    Prefix       => 'foo',
+                    Value        => 42,
+                },
+            },
+            Name         => 'foo:bar',
+            LocalName    => 'bar',
+            NamespaceURI => $TEST_NS,
+            Prefix       => 'foo',
+        },
+        expected => {
+            Attributes => {
+                "{$TEST_NS}baz" => {
+                    LocalName    => 'baz',
+                    Name         => 'foo:baz',
+                    NamespaceURI => $TEST_NS,
+                    Prefix       => 'foo',
+                    Value        => 42,
+                },
+            },
+            LocalName    => 'bar',
+            Name         => 'foo:bar',
+            NamespaceURI => $TEST_NS,
+            Prefix       => 'foo',
+        },
+    },
+    #----------------------------------------
+    {
+        desc => 'corrects missing Name in Attribute',
+        ns   => [ [ foo => $TEST_NS ] ],
+        in   => {
+            Attributes => {
+                "{$TEST_NS}baz" => {
+                    LocalName    => 'baz',
+                    NamespaceURI => $TEST_NS,
+                    Prefix       => 'foo',
+                    Value        => 42,
+                },
+            },
+            Name         => 'foo:bar',
+            LocalName    => 'bar',
+            NamespaceURI => $TEST_NS,
+            Prefix       => 'foo',
+        },
+        expected => {
+            Attributes => {
+                "{$TEST_NS}baz" => {
+                    LocalName    => 'baz',
+                    Name         => 'foo:baz',
+                    NamespaceURI => $TEST_NS,
+                    Prefix       => 'foo',
+                    Value        => 42,
+                },
+            },
+            LocalName    => 'bar',
+            Name         => 'foo:bar',
+            NamespaceURI => $TEST_NS,
+            Prefix       => 'foo',
+        },
+    },
 );
 test_correct_element_data( $_ ) foreach @test_data;