Added basic search for config file #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happylinks
reviewed
Dec 7, 2018
There was a problem hiding this comment.
Thanks for this PR! I tested it myself and it seems to work great.
I added one comment about the console.error, and do we need to add a yarn.lock file? I already have the package-lock, not sure if two lockfiles is needed. (this would also mean we have to keep both up to date all the time)
If you can fix those I can merge it and release a new version.
- added .prettierrc to maintain rules for editors to follow - added an order of precedence for filepaths - changed could not parse config error to use correct variable for the case where the config filename was changed
|
Awesome, I just published this as version 1.8.0. |
|
ok, will do. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
where the config filename was changed