Remove "Add New" for shadow taxonomies

[s3rgiosan]

This pull request addresses this #20

[s3rgiosan]

Tagging @jeremyfelt for visibility.

[jeremyfelt]

@s3rgiosan Thank you for the pull request! I took a look and was having a bit of trouble when a shadow taxonomy had more than somewhere around 5 terms. At that point, the UI shifts in the block editor and adds the search box above the list. Removing the action-create- pattern seems to make it so that only the search box remains. The list of terms is removed with the Add New option.

I started poking around at a way to work around it, but then it hit me that we may be able to use capabilities instead. In #46, I've changed the taxonomy registration so that the override_shadow_terms capability (which no user has) is required to add or manage terms. I believe this does the trick, or has in my testing so far.

Can you take a look at that and let me know if it works for your use case?

Separately, I'm intrigued by https://github.com/happyprime/shadow-terms/pull/45/files#diff-88cbf32328b8063e81b548feddc5e234b8a1b7593b71560b31dc300f52151284R260-R284 in your PR, which adds a shadow taxonomy identifier in REST responses. Is that something that would be useful as a whole?

Thanks!

[s3rgiosan]

Can you take a look at that and let me know if it works for your use case?

Absolutely. I'll test it out asap.

Separately, I'm intrigued by https://github.com/happyprime/shadow-terms/pull/45/files#diff-88cbf32328b8063e81b548feddc5e234b8a1b7593b71560b31dc300f52151284R260-R284 in your PR, which adds a shadow taxonomy identifier in REST responses. Is that something that would be useful as a whole?

I have a use case where the block editor, with its blocks and term selection panels, doesn't align well with the whole editing experience.
I've implemented a custom post type named 'Game Result' and a custom post type named 'Team'. The relation between these two post types is made through a 'Team' shadow taxonomy created using the 'Shadow Terms' plugin.
Each time a content editor creates a game result, it inputs data into specific fields and selects from two different dropdowns the home team and the away team ('Team' shadow taxonomy terms).
This is all done in a wizard-type block in the block editor, providing a similar experience to what we have with the new WooCommerce product creation screen.

In order for this to work, I had to integrate in the block some of the logic we have in PHP. For example, determining if a taxonomy is a shadow taxonomy or not. I believe that exposing some of that logic in the REST responses, would simplify this kind of development.

[s3rgiosan]

Hi @jeremyfelt

I took a look and was having a bit of trouble when a shadow taxonomy had more than somewhere around 5 terms. At that point, the UI shifts in the block editor and adds the search box above the list. Removing the action-create- pattern seems to make it so that only the search box remains. The list of terms is removed with the Add New option.

I tested out in my local environment and with more than 5 terms I get the search box above the term list, and no "Add New" button, with both my PR and yours #46

For comparison:
trunk

s3rgiosan:feature/remove-add-new

fix/20-remove-add-new

Your approach feels way less hacky than mine 🚀🙌

Please don't hesitate to close my PR if you don't see a need for https://github.com/happyprime/shadow-terms/pull/45/files#diff-88cbf32328b8063e81b548feddc5e234b8a1b7593b71560b31dc300f52151284R260-R284

[s3rgiosan]

I actually need some additional information in those REST endpoints to avoid having logic in the blocks that can be provided in PHP. I'm going to work on that and update this PR.