Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing nested selectors with cssSelectorAncestor #342

Closed
wants to merge 1 commit into from
Closed

Allowing nested selectors with cssSelectorAncestor #342

wants to merge 1 commit into from

Conversation

ReactiveRaven
Copy link

#341

Allows selectors for play/pause buttons etc with css groups (ie: ".play, .pause, .stop") which were previously being interpreted as "#ancestor .play, .pause, .stop", ie:

#ancestor .play,
.pause,
.stop

which caused the .pause and .stop buttons to bind to all players on the page.

context also updated to retain old behaviour.

#341

Allows selectors for play/pause buttons etc with css groups (ie: ".play, .pause, .stop") which were previously being interpreted as "#ancestor .play, .pause, .stop", ie:

```
#ancestor .play,
.pause,
.stop
```

which caused the `.pause` and `.stop` buttons to bind to all players on the page.

context also updated to retain old behaviour.
@thepag
Copy link
Contributor

thepag commented Dec 22, 2015

Not sure why you need this. jPlayer already works in the way you describe.
http://jplayer.org/latest/developer-guide/#jPlayer-predefined-css-selectors

@ReactiveRaven
Copy link
Author

Yeah, I guess I chose bad examples here with the classes, the actual issue we have is multiple play/pause buttons in different places on the page. So we have one in the controls beneath a video, one over the video initially, another one when zooming the video to cover the page, that kind of thing. I was doing this with someone my ride waiting outside of work, sorry :)

So, with an example like:

  • ancestor: #ancestor
  • play: .control-play, .cover-play, .zoom-play

the constructed selector looks like: #ancestor .control-play, .cover-play, .zoom-play - which selects like:

#ancestor .control-play,
.cover-play,
.zoom-play

Hope that makes more sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants