Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container leve securityContext and missing probes #31

Merged
merged 4 commits into from
Oct 20, 2021

Conversation

michalschott
Copy link
Contributor

@michalschott michalschott commented Sep 30, 2021

Currently it is unable to set for example readOnlyRootFilesystem in security context as this is set per container basis.
Probes for access-logs container are not defined.

This PR fixes above problems.

@michalschott michalschott changed the title Allow to configre securityContext at container level. Few improvements - securityContext, missing probes Oct 13, 2021
@jcmoraisjr
Copy link
Member

Hi thanks for the improvements! Sorry about taking so long to answer. Some suggestions below:

  • what about add a distinct securityContext under controller.haproxy and use it in the haproxy container?
  • please add also the new entries in the readme file.

@michalschott
Copy link
Contributor Author

@jcmoraisjr pushed an update with your suggestions.

@jcmoraisjr
Copy link
Member

Lgtm thanks! Merging.

@jcmoraisjr jcmoraisjr changed the title Few improvements - securityContext, missing probes Add container leve securityContext and missing probes Oct 20, 2021
@jcmoraisjr jcmoraisjr merged commit 36890e0 into haproxy-ingress:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants