Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Gateway api v1 #609

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Use Gateway api v1 #609

wants to merge 9 commits into from

Conversation

eltorio
Copy link

@eltorio eltorio commented Jan 31, 2024

  • reference grant still v1beta1
  • tcp route still v1alpha2

Copy link

stale bot commented Mar 1, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 1, 2024
@oktalz oktalz removed the stale label Mar 11, 2024
@oktalz
Copy link
Member

oktalz commented Mar 11, 2024

hi @eltorio,
if you haven't seen, CI is failing on this PR due to our policy for commit messages.
Usually I would suggest squashing messages, but this is not possible since more that one author has created those.

The easiest way to figure out what is the form of commit messages can be seen if you look at the git history.
Reasons how and most importantly why, can be seen here CONTRIBUTING

Unfortunately until this is resolved, we can't accept this PR.

PS. there one more open #608, almost with similar idea, but i guess this one is newer version ?

@oktalz oktalz added the enhancement New feature or request label Mar 22, 2024
@git001
Copy link

git001 commented Apr 3, 2024

@eltorio any chance to work on the fix for the PR ?

@eltorio
Copy link
Author

eltorio commented Apr 3, 2024

Sure I need to check but I have a lot of work!
Since I made some other modifications I need to clean some things.
My fork continued its own life.
For example for our need it supports an annotation for enabling haproxy v2 protocol on tcproute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants