Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spline3D.computeVertices duplicates #26

Closed
czerwonypolar opened this issue Jan 14, 2014 · 1 comment
Closed

Spline3D.computeVertices duplicates #26

czerwonypolar opened this issue Jan 14, 2014 · 1 comment

Comments

@czerwonypolar
Copy link

Spline3D.computeVertices method produces duplicate vertices at spline's control points unlike Java version. Another difference is the number of segments in between control points, which is one less then resolution.
hapticdata added a commit that referenced this issue Jan 19, 2014
@hapticdata
bugfix issue #26 Spline3D (and 2D) ending with incorrect number of
ee236b3 
points, tested and compared to java output, BernsteinPolynomial output
tested as well
hapticdata added a commit that referenced this issue Jan 19, 2014
@hapticdata
v0.2.3 bugfix issue #26
b958c64
@hapticdata
Copy link
Owner

Thank you for bringing this to my attention! I have fixed the issue which also effected Spline2D. The Spline3D unit test now includes sample outputs from the Java version at several resolutions and proves the output to be identical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hapticdata @czerwonypolar