Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React-confirm using really old react dependency #13

Closed
vesakilp opened this issue Sep 4, 2017 · 4 comments
Closed

React-confirm using really old react dependency #13

vesakilp opened this issue Sep 4, 2017 · 4 comments

Comments

@vesakilp
Copy link

vesakilp commented Sep 4, 2017

Used react dependency is really old, and leads to problems with shrinkwrap, basically it can't be used when using new react versions.

@joshwcomeau
Copy link
Contributor

Yeah, I'm using it with React 16 and it works without issue (really great project, by the way, @haradakunihiko!). Should be a simple matter of incrementing the peerDependency to ^0.14.7 || 15.x || 16.x

@haradakunihiko
Copy link
Owner

Thanks for using react-confirm. I'd really like to modify and also update the example to use the latest React version, but currently have no time for this.
Could you kindly create a PR for this if possible?

@joshwcomeau
Copy link
Contributor

Sent a quick PR that adds the peer dependency update, and changes the example in the README to use prop-types package (since PropTypes is no longer included in React).

I just saw that there are also a couple example apps, which I realize now is probably what you meant by "update the example", but I'm afraid I don't quite have time for that. FWIW, I don't believe anything else needs to change other than moving PropTypes and createClass (if used) into separate packages.

@haradakunihiko
Copy link
Owner

Thanks for the PR, your comment was helpful since I haven't used react for a while.
Merged and published. (Maybe I will release again once react@16 are published. )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants