Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config overriding for core modules #1468

Merged
merged 1 commit into from
May 18, 2016
Merged

Conversation

baudehlo
Copy link
Collaborator

Fixes #1467

@baudehlo baudehlo merged commit ed41ac4 into master May 18, 2016
@msimerson
Copy link
Member

/me smells a 2.8.3 release soon...

@msimerson msimerson deleted the core_config_merging branch May 18, 2016 16:59
@baudehlo
Copy link
Collaborator Author

Well, 2.8.2 - you released 2.8.1 but changed it to 2.8.2 in changes for
some reason :)

On Wed, May 18, 2016 at 12:59 PM, Matt Simerson notifications@github.com
wrote:

/me smells a 2.8.3 release soon...


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
#1468 (comment)

@msimerson
Copy link
Member

2.8.1 was released to npm as 2.8.2, because an unnamed person got a step ahead of himself in the release process checklist. So next up is 2.8.3.

@baudehlo
Copy link
Collaborator Author

Oh boy. :)

On Wed, May 18, 2016 at 1:19 PM, Matt Simerson notifications@github.com
wrote:

2.8.1 was released to npm as 2.8.2, because an unnamed person got a step
ahead of himself in the release process checklist. So next up is 2.8.3.


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
#1468 (comment)

@msimerson
Copy link
Member

Yeah, it's nearly time someone writes haraka-release.sh, so we can automatically screw up the releases. ;-)

@baudehlo
Copy link
Collaborator Author

I used to use shipit for perl modules. I expect there's something similar.

On Wed, May 18, 2016 at 1:22 PM, Matt Simerson notifications@github.com
wrote:

Yeah, it's nearly time someone writes haraka-release.sh, so we can
automatically screw up the releases. ;-)


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
#1468 (comment)

@msimerson
Copy link
Member

I've tried a number of them with perl, everything from cpan-release (very minimal) to dist::zilla (very maximal) and I'd much prefer something like:

sed -i .bak -e 's/Mon DD/May 18/' \
    && cd ../haraka-tld && ./update_tld_files && ./bump_version && npm release \
    && cd ../haraka && ./bump_version \
    && grunt versioncheck \
    && ./update_changes_from_git_history \
    && git tag -vN.N.N && git push --tags \
    && npm test \
    && git commit -m 'release version N.N.N' \
    && npm publish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants