New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't put private key in logs #1565

Merged
merged 1 commit into from Aug 16, 2016

Conversation

Projects
None yet
2 participants
@baudehlo
Collaborator

baudehlo commented Aug 16, 2016

Fixes #1557

Changes proposed in this pull request:

  • Don't put the private key in the logs, duh!
Matt Sergeant
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 16, 2016

Current coverage is 36.03% (diff: 100%)

Merging #1565 into master will not change coverage

@@             master      #1565   diff @@
==========================================
  Files            26         26          
  Lines          6489       6489          
  Methods         843        843          
  Messages          0          0          
  Branches       1693       1693          
==========================================
  Hits           2338       2338          
  Misses         4151       4151          
  Partials          0          0          

Powered by Codecov. Last update 900537a...c0305bb

codecov-io commented Aug 16, 2016

Current coverage is 36.03% (diff: 100%)

Merging #1565 into master will not change coverage

@@             master      #1565   diff @@
==========================================
  Files            26         26          
  Lines          6489       6489          
  Methods         843        843          
  Messages          0          0          
  Branches       1693       1693          
==========================================
  Hits           2338       2338          
  Misses         4151       4151          
  Partials          0          0          

Powered by Codecov. Last update 900537a...c0305bb

@baudehlo baudehlo merged commit d059281 into master Aug 16, 2016

3 checks passed

codecov/project 36.03% (+0.00%) compared to 900537a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@baudehlo baudehlo deleted the private_key_log_hide branch Aug 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment