Do not create a top level secureContext #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes problems because the secureContext ends up being used by Haraka in server and client mode. Currently, the server mode loads TLS keys as part of the context in (plugins/tls_socket). The client mode does not load keys (in smtp_client.js). This discrepancy causes tls connections to fail when there is an incoming mail immediately followed by an outgoing mail.
Current coverage is 36.11% (diff: 0.00%)@@ master #1787 diff @@
==========================================
Files 22 22
Lines 5795 5792 -3
Methods 750 750
Messages 0 0
Branches 1454 1453 -1
==========================================
- Hits 2093 2092 -1
+ Misses 3702 3700 -2
Partials 0 0
|
|
This was the root cause for #1768. To reproduce this manually:
|
|
I think this is fine, but I'd like to test this before merging. I'll try to get that done tomorrow. |
msimerson
reviewed
Jan 29, 2017
|
|
||
| secureContext = tls.createSecureContext(options); | ||
| var secureContext = tls.createSecureContext(options); | ||
| return secureContext; |
There was a problem hiding this comment.
Might as well remove the variable declaration entirely and just return tls.createSecureContext(options);
msimerson
requested changes
Jan 29, 2017
|
I've made the change in the PR. Do you agree @gramakri? |
|
@msimerson yes, OK with me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes problems because the secureContext ends up being used by
Haraka in server and client mode. Currently, the server mode loads
TLS keys as part of the context in (plugins/tls_socket). The client
mode does not load keys (in smtp_client.js). This discrepancy causes
tls connections to fail when there is an incoming mail immediately
followed by an outgoing mail.