Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration test: end to end server testing #1791

Merged
merged 9 commits into from
Jan 31, 2017
Merged

integration test: end to end server testing #1791

merged 9 commits into from
Jan 31, 2017

Conversation

msimerson
Copy link
Member

@msimerson msimerson commented Jan 31, 2017

Fixes #1725

Changes proposed in this pull request:

  • add server integration test: starts up a Haraka server and delivers an email using nodemailer
  • replace TLS cert/key stubs with self-signed certs, so they're usable
  • replace test/config/dhparam key with 2048 key (so nodemailer doesn't kvetch)
  • remove logger.colorize code for legacy node version
  • trailing whitespace in comment removed
  • tests/plugins: after setting for tests, unset process.env.HARAKA and avoid side effects that interfere with other tests (like my new one)
  • queue/discard: add ENV that permits discarding via ENV variable, b/c integration tests don’t have access to the connection/transaction object
  • outbound: set queue_dir to tests/test-queue when env.HARAKA unset. It’s a more sane default than ‘/path/to/haraka/undefined/queue’
  • tls.ini: add missing .pem extension to dhparams comment
  • plugins: export config, so tests can overload it

Checklist:

  • tests updated

@codecov-io
Copy link

codecov-io commented Jan 31, 2017

Codecov Report

Merging #1791 into master will increase coverage by 10.03%.

@@             Coverage Diff             @@
##           master    #1791       +/-   ##
===========================================
+ Coverage   36.12%   46.16%   +10.03%     
===========================================
  Files          22       22               
  Lines        5793     5805       +12     
  Branches     1453     1457        +4     
===========================================
+ Hits         2093     2680      +587     
+ Misses       3700     3125      -575
Impacted Files Coverage Δ
logger.js 81.1% <ø> (+3.75%)
config.js 90.27% <100%> (+0.42%)
outbound.js 11.45% <30.76%> (+0.18%)
server.js 33.7% <54.16%> (+14.04%)
plugins.js 73.52% <75%> (+23.2%)
configfile.js 70% <ø> (+0.29%)
messagestream.js 73.49% <ø> (+4.41%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 812739b...aade194. Read the comment docs.

@msimerson msimerson added this to the 100% test coverage milestone Jan 31, 2017
and avoid side effects that interfere with other tests
b/c integration tests don’t have access to the connection/transaction
object
for tests. it’s a more sane default than
‘/path/to/haraka/undefined/queue’
(was missing .pem extension)
- starts up a server, sends an email using nodemailer@2
@msimerson msimerson merged commit 5d45399 into haraka:master Jan 31, 2017
@msimerson msimerson deleted the 1725-end-to-end-server-test branch January 31, 2017 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants