Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap lines to fix missing inherited methods #1793

Merged
merged 1 commit into from
Jan 31, 2017

Conversation

EyePulp
Copy link
Collaborator

@EyePulp EyePulp commented Jan 31, 2017

Fix a transposed pair of lines in plugins/dnswl.js

    plugin.load_dnswl_ini();
    plugin.inherits('dns_list_base');

plugin.load_dnswl_ini() attempts to use inherited methods, which aren't yet present. A line swap fixes it.

@msimerson
Copy link
Member

Mmmm, I see the problem. load_dnswl_ini() isn't an inherited function, it's actually in dnswl.js, but I'll merge this (b/c I think inheritance should come first) and fix the problem you're seeing in another PR.

@msimerson msimerson merged commit 13c34f4 into haraka:master Jan 31, 2017
@EyePulp
Copy link
Collaborator Author

EyePulp commented Jan 31, 2017

I could have phrased it better - there's a conditional call inside load_dnswl_ini() that does call on the inherited check_zones() function here:
https://github.com/haraka/Haraka/blob/master/plugins/dnswl.js#L39-L41

@EyePulp EyePulp deleted the dnswl-inherit-fix branch January 31, 2017 16:58
@msimerson
Copy link
Member

Ahhhh, right you are. Good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants