Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dkim: converted classes to ES6 #2206

Merged
merged 1 commit into from Oct 12, 2017
Merged

Conversation

CalgaryMichael
Copy link
Contributor

Fixes #2133

Changes proposed in this pull request:

  • Convert the current classes in dkim module to ES6

Checklist:

  • docs updated
  • tests updated
  • Changes updated

@codecov
Copy link

codecov bot commented Oct 12, 2017

Codecov Report

Merging #2206 into master will decrease coverage by 0.03%.
The diff coverage is 71.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2206      +/-   ##
==========================================
- Coverage   59.55%   59.52%   -0.04%     
==========================================
  Files          28       28              
  Lines        6043     6043              
  Branches     1496     1496              
==========================================
- Hits         3599     3597       -2     
- Misses       2444     2446       +2
Impacted Files Coverage Δ
dkim.js 75% <71.22%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c428e5f...436d881. Read the comment docs.

Copy link
Member

@msimerson msimerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msimerson msimerson merged commit 8a52426 into haraka:master Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants