Fix docs for Address objects
#2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2224 +/- ##
=======================================
Coverage 59.41% 59.41%
=======================================
Files 28 28
Lines 6051 6051
Branches 1497 1497
=======================================
Hits 3595 3595
Misses 2456 2456Continue to review full report at Codecov.
|
msimerson
reviewed
Oct 19, 2017
| @@ -361,3 +361,5 @@ In case you need notes in the new transaction that `send_email()` creates, you s | |||
| ```notes``` option, like so: | |||
|
|
|||
| outbound.send_email(from, to, contents, outnext, { notes: transaction.notes }); | |||
|
|
|||
| [1]: `Address` objects are address-rfc2821 objects. See https://github.com/haraka/node-address-rfc2821 | |||
There was a problem hiding this comment.
Recursive links?
[1]: Address objects are instances of address-rfc2821.
source:
[1]: Address objects are instances of [address-rfc2821](https://github.com/haraka/node-address-rfc2821).
msimerson
approved these changes
Oct 19, 2017
|
Fair enough, though github's markdown viewer does turn them into links, so shrug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2220
Changes proposed in this pull request:
Addressobjects to the node module behind them.Checklist: