Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bounced_rcpt for bounce hook #2899

Merged
merged 2 commits into from
Jan 11, 2021
Merged

fix bounced_rcpt for bounce hook #2899

merged 2 commits into from
Jan 11, 2021

Conversation

pekapl
Copy link
Contributor

@pekapl pekapl commented Jan 11, 2021

Changes proposed in this pull request:

  • fix bounced_rcpt parameter passed to bounce hook

msimerson
msimerson approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@msimerson msimerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I traced this to the initial addition in commit 3201299 and the arguments passed in the code (rcpt) do not match the docs (bounced_recips). This PR fixes that.

@msimerson msimerson merged commit 74f231c into haraka:master Jan 11, 2021
gramakri added a commit to cloudron-io/Haraka that referenced this pull request Jan 14, 2021
@gramakri
fix fail_recips for bounce hook
2935a70 
the bounce logic sets this as deferred_rcpt when calling the bounce hook

fix is similar to haraka#2899
@gramakri gramakri mentioned this pull request Jan 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimerson msimerson msimerson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pekapl @msimerson