Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove not-an-error error message #3034

Merged
merged 2 commits into from
Apr 2, 2022

Conversation

msimerson
Copy link
Member

@msimerson msimerson commented Apr 2, 2022

Changes proposed in this pull request:

  • don't emit an error after deciding not to skip signing a message and logging why
Apr  2 07:48:29 [INFO] [] [dkim_verify] identity="@online.costco.com" domain="online.costco.com" selector="key1" result=pass
Apr  2 07:48:29 [NOTICE] [-] [dkim_sign] skipped: no private key for online.costco.com
Apr  2 07:48:29 [ERROR] [-] [core] missing key data for undefined.online.costco.com
Apr  2 07:48:30 [NOTICE] [] [core] disconnect ip=67.90.142.249 rdns=mta16v7.online.costco.com helo=mta16v7.online.costco.com relay=N early=N esmtp=Y tls=Y pipe=N errors=0 txns=1 rcpts=1/0/0 msgs=1/0/0 bytes=211031 lr="" time=8.286

Checklist:

  • docs updated
  • tests updated
  • Changes updated

@msimerson msimerson merged commit 46dd14e into haraka:master Apr 2, 2022
@msimerson msimerson deleted the dkim-sign-spurious-error branch April 2, 2022 15:28
@msimerson msimerson mentioned this pull request Jun 4, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant