Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make milter header handling compatible with rspamd 3.3 #30

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

pvagner
Copy link
Contributor

@pvagner pvagner commented Oct 8, 2022

Fixes #29

Signed-off-by: Peter Vágner pvdeejay@gmail.com

Fixes #

Changes proposed in this pull request:

Checklist:

  • docs updated
  • tests updated
  • Changes.md updated

Peter Vágner added 2 commits October 8, 2022 23:13
Signed-off-by: Peter Vágner <pvdeejay@gmail.com>
Signed-off-by: Peter Vágner <pvdeejay@gmail.com>
Copy link
Member

@msimerson msimerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Have you tested this code with rspamd 3.3 and 3.2?

@pvagner
Copy link
Contributor Author

pvagner commented Oct 10, 2022

Hello,
I am using this with rspamd 3.3 since I've come up with it.
I have just tested a few messages with the patch applied and rspamd 2.2 just to verify it's working for me.
So I'd say all is good.

@msimerson msimerson merged commit 946a799 into haraka:master Oct 10, 2022
@msimerson msimerson mentioned this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'replace')
2 participants