Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of pkg_resources when not supporting Python 3.7 any more #1234

Closed
felixdivo opened this issue Jan 27, 2022 · 0 comments · Fixed by #1597
Closed

Remove use of pkg_resources when not supporting Python 3.7 any more #1234

felixdivo opened this issue Jan 27, 2022 · 0 comments · Fixed by #1597
Labels
api minor QA about improving and maintaining the quality of the library
Milestone

Comments

@felixdivo
Copy link
Collaborator

Currently, a fallback to pkg_resources.iter_entry_points is used in can/interfaces/__init__.py. However, the setuptools docs state:

Use of pkg_resources is discouraged in favor of importlib.resources, importlib.metadata, and their backports (resources, metadata). Please consider using those libraries instead of pkg_resources.

On Python 3.8+, importlib.metadata is part of the standard library, so there should be no need to keep pkg_resources.iter_entry_points around, right?

The PR #1110 is related.

@felixdivo felixdivo added minor QA about improving and maintaining the quality of the library labels Jan 27, 2022
@felixdivo felixdivo added the api label Feb 4, 2022
@felixdivo felixdivo added this to the Next Release milestone Feb 4, 2022
@felixdivo felixdivo modified the milestones: 4.1.0 Release, Next Release Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api minor QA about improving and maintaining the quality of the library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant