Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise Minimum Python Version to 3.8 #1597

Merged
merged 4 commits into from
May 20, 2023
Merged

Raise Minimum Python Version to 3.8 #1597

merged 4 commits into from
May 20, 2023

Conversation

zariiii9003
Copy link
Collaborator

Also, remove pkg_resources and the setuptools runtime dependency. Closes #1234

hardbyte
hardbyte approved these changes May 20, 2023
View reviewed changes
Copy link
Owner

@hardbyte hardbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job.

I didn't dig deep into the entrypoint changes but everything else looks good to me.

@zariiii9003 zariiii9003 merged commit 1a3f5e3 into hardbyte:develop May 20, 2023
26 checks passed
@zariiii9003 zariiii9003 deleted the py38 branch May 20, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardbyte hardbyte hardbyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove use of pkg_resources when not supporting Python 3.7 any more
2 participants
@zariiii9003 @hardbyte