Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCAN doesn't exit cleanly #26

Closed
hardbyte opened this issue Apr 23, 2015 · 5 comments
Closed

PCAN doesn't exit cleanly #26

hardbyte opened this issue Apr 23, 2015 · 5 comments

Comments

@hardbyte
Copy link
Owner

Originally reported by: Jack Weinstein (Bitbucket: jacklev, GitHub: jacklev)


On 2.7 the PCAN interface doesn't release the net it creates. Should have a method in pcan.py that looks like this:

def shutdown(self):
    self.m_objPCANBasic.Uninitialize(self.m_PcanHandle)

@hardbyte
Copy link
Owner Author

Original comment by Brian Thorne (Bitbucket: hardbyte, GitHub: hardbyte):


Would you like to create a pull request for this change Jack? I don't have access to PCAN hardware so hopefully someone else can test/review.

@hardbyte
Copy link
Owner Author

Original comment by Jack Weinstein (Bitbucket: jacklev, GitHub: jacklev):


Brian, gladly - I'm not having success pushing from SourceTree though. Could you give me the necessary access to start a new branch and pull request? Or link me to an explanation of the workflow I should use (I'm new to using Bitbucket :)).

@hardbyte
Copy link
Owner Author

Original comment by Brian Thorne (Bitbucket: hardbyte, GitHub: hardbyte):


Sure, you should be able to do the fork + PR reasonably easily but if you run into trouble post back here and I'll give you access to this repository. As with github though, usually you would make a few pull requests before given direct access.

Bitbucket has a nice tutorial: https://confluence.atlassian.com/display/BITBUCKET/Fork+a+Repo,+Compare+Code,+and+Create+a+Pull+Request

@hardbyte
Copy link
Owner Author

Original comment by Jack Weinstein (Bitbucket: jacklev, GitHub: jacklev):


Very belatedly - thanks! This was my first open source contribution, so I appreciate your patience. FWIW I'm hoping to use your library for some automated testing at Tesla, should be pretty cool.

@hardbyte
Copy link
Owner Author

Original comment by Brian Thorne (Bitbucket: hardbyte, GitHub: hardbyte):


Oh that is exciting, its great to hear where the library is being used. I drove a Model S for the first time on Sunday and loved it.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant