Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

**config vs **kwargs #492

Closed
PeteAndersen opened this issue Jan 16, 2019 · 3 comments
Closed

**config vs **kwargs #492

PeteAndersen opened this issue Jan 16, 2019 · 3 comments
Assignees
@PeteAndersen
Labels
enhancement good first contribution minor
Milestone
3.2 Release

Comments

@PeteAndersen
Copy link

PeteAndersen commented Jan 16, 2019 •
edited
Loading

When naming the keyword arguments variable, the standard convention in python is to call it kwargs. Naming it config tends to throw off some introspection tools. Would you consider a PR to rename them to kwargs across the board?

Example: https://github.com/hardbyte/python-can/blob/develop/can/bus.py#L36
@hardbyte
Copy link
Owner

Sure, I'd merge that

@PeteAndersen
Copy link
Author

Great! I'll have a PR ready in a couple days after some travel

@felixdivo felixdivo added this to the 3.2 Release milestone Feb 23, 2019
@felixdivo
Copy link
Collaborator

@PeteAndersen Any updates on this ❓

PeteAndersen pushed a commit to PeteAndersen/python-can that referenced this issue Mar 20, 2019
Updated instances of **config to **kwargs, closes hardbyte#492
cf76785
@PeteAndersen PeteAndersen mentioned this issue Mar 21, 2019
Merged
felixdivo pushed a commit that referenced this issue Mar 21, 2019
@felixdivo
Updated instances of **config to **kwargs, closes #492
b6c8752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PeteAndersen PeteAndersen

Labels
enhancement good first contribution minor
Projects
None yet
Milestone
3.2 Release
Development

No branches or pull requests
3 participants
@hardbyte @felixdivo @PeteAndersen