Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ixxat driver ignores UniqueHardwareID and [r|t]xFifoSize from configuration #702

Closed
cranium-xx opened this issue Sep 16, 2019 · 6 comments · Fixed by #1062
Closed

Ixxat driver ignores UniqueHardwareID and [r|t]xFifoSize from configuration #702

cranium-xx opened this issue Sep 16, 2019 · 6 comments · Fixed by #1062

Comments

@cranium-xx
Copy link

The Ixxat canlib ignores UniqueHardwareID, rxFifoSize and txFifoxSize from the configuration file.
The reason is that the driver requests the configuration with CamelCase but it has to use lower case.

@felixdivo
Copy link
Collaborator

Can you provide a pull request solving the problem?

@cranium-xx
Copy link
Author

Of course, I can. I just need the rights to create an branch for it. How do I get them?

@felixdivo
Copy link
Collaborator

Cool! The usual workflow is to fork (upper right corner of the page) and then apply the changes to the forked develop branch of cranium-xx/python-can. Then in your fork, you should see a button for merging it back into hardbyte/python-can.

@felixdivo
Copy link
Collaborator

@cranium-xx This is very old. Do you plan on providing a patch?

@cranium-xx
Copy link
Author

Hi,
I just provided a patch.

@felixdivo
Copy link
Collaborator

Great I'll have a look over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants