Preserve capitalization when reading config files #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably solved by #1061. I also just canceled a lot of hanging irrelevant jobs with thew faulty config and now everything seems to be working again. |
Codecov Report
@@ Coverage Diff @@
## develop #1062 +/- ##
===========================================
+ Coverage 70.81% 70.87% +0.05%
===========================================
Files 79 79
Lines 7611 7612 +1
===========================================
+ Hits 5390 5395 +5
+ Misses 2221 2217 -4 |
zariiii9003
approved these changes
Jun 3, 2021
|
@Mergifyio rebase |
|
Command
|
hardbyte
force-pushed
the
fix-capitalization-in-parameter-files
branch
from
5a1d46a
to
0c28328
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was discussed in #1020, where @cranium-xx worked on a fix for #702. Previously, all parameters were converted to lower case, and some parameters with upper case naming could therefore not be set. This is fixed by this PR.
Fix #702.