Specific Exceptions: Adapting pcan interface

[felixdivo]

Part of #1046.

Also partly cleans up the docstrings in basic.py and uses some subtests in test_pcan.py (the parameter name was else unused in most parameterized tests).

[codecov]

Codecov Report

Merging #1152 (02b288d) into develop (9080c47) will increase coverage by 0.01%.
The diff coverage is 82.60%.

@@             Coverage Diff             @@
##           develop    #1152      +/-   ##
===========================================
+ Coverage    70.86%   70.88%   +0.01%     
===========================================
  Files           79       79              
  Lines         7765     7770       +5     
===========================================
+ Hits          5503     5508       +5     
  Misses        2262     2262              

[felixdivo]

This change prevents a hypothetical error if self.status() changes between lines.

[felixdivo]

@Mergifyio rebase

[mergify]

rebase

✅ Branch has been successfully rebased

[felixdivo]

What a weird failure:

_____________ TestBaseRotatingLogger.test_rotate_without_rotator ______________

self = <test.test_rotating_loggers.TestBaseRotatingLogger object at 0x000001b81f183590>
tmp_path = WindowsPath('C:/Users/runneradmin/AppData/Local/Temp/pytest-of-unknown/pytest-0/test_rotate_without_rotator0')

    def test_rotate_without_rotator(self, tmp_path):
        logger_instance = self._get_instance(tmp_path)
    
        source = str(tmp_path / "source.txt")
        dest = str(tmp_path / "dest.txt")
    
        assert os.path.exists(source) is False
        assert os.path.exists(dest) is False
    
        logger_instance._get_new_writer(source)
        logger_instance.stop()
    
        assert os.path.exists(source) is True
        assert os.path.exists(dest) is False
    
>       logger_instance.rotate(source, dest)

test\test_rotating_loggers.py:99: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <test.test_rotating_loggers.TestBaseRotatingLogger._get_instance.<locals>.SubClass object at 0x000001b81f183a28>
source = 'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-unknown\\pytest-0\\test_rotate_without_rotator0\\source.txt'
dest = 'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-unknown\\pytest-0\\test_rotate_without_rotator0\\dest.txt'

    def rotate(self, source: StringPathLike, dest: StringPathLike) -> None:
        """When rotating, rotate the current log.
    
        The default implementation calls the :attr:`rotator` attribute of the
        handler, if it's callable, passing the source and dest arguments to
        it. If the attribute isn't callable (the default is `None`), the source
        is simply renamed to the destination.
    
        :param source:
            The source filename. This is normally the base
            filename, e.g. `"test.log"`
        :param dest:
            The destination filename. This is normally
            what the source is rotated to, e.g. `"test_#001.log"`.
        """
        if not callable(self.rotator):
            if os.path.exists(source):
>               os.rename(source, dest)
E               PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-unknown\\pytest-0\\test_rotate_without_rotator0\\source.txt' -> 'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-unknown\\pytest-0\\test_rotate_without_rotator0\\dest.txt'

can\io\logger.py:177: PermissionError

[felixdivo]

What a weird failure:

Will be fixed by a6256e8 as soon as #1166 is merged

[felixdivo]

@Mergifyio rebase

[mergify]

rebase

✅ Branch has been successfully rebased

[felixdivo]

@hardbyte Do you think you'll have time to review the open RPs for the 4.0.0 Release in the near future? There are also a few PRs that are approved by others and are waiting to be merged. It would be nice to include them into the next release (but the main blocker are the PRs around Specific Exceptions).