Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix channel2int conversion #1269

Merged
merged 2 commits into from Mar 9, 2022
Merged

Conversation

zariiii9003
Copy link
Collaborator

Closes #1268

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #1269 (068cc2c) into develop (4d9b32c) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1269      +/-   ##
===========================================
+ Coverage    66.02%   66.07%   +0.04%     
===========================================
  Files           86       86              
  Lines         8912     8913       +1     
===========================================
+ Hits          5884     5889       +5     
+ Misses        3028     3024       -4     

@zariiii9003 zariiii9003 added the bug label Mar 2, 2022
@hartkopp
Copy link
Collaborator

hartkopp commented Mar 2, 2022

Excellent! Thanks for the quick fix!

@zariiii9003 zariiii9003 added this to the 4.0.1 milestone Mar 3, 2022
test/test_util.py Show resolved Hide resolved
Co-authored-by: Felix Divo <4403130+felixdivo@users.noreply.github.com>
@zariiii9003 zariiii9003 merged commit b92ee5a into hardbyte:develop Mar 9, 2022
@zariiii9003 zariiii9003 deleted the fix_1268 branch March 9, 2022 07:54
@felixdivo felixdivo modified the milestones: 4.0.1, 4.1.0 Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

channel2int() defect in Vector ASC conversion (from SocketCAN log format) ??
3 participants