New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mf4 io #1289
Mf4 io #1289
Conversation
mf4-io can probably be deleted, should this be merged. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1289 +/- ##
===========================================
+ Coverage 65.16% 65.60% +0.44%
===========================================
Files 81 82 +1
Lines 8853 9074 +221
===========================================
+ Hits 5769 5953 +184
- Misses 3084 3121 +37 |
@driftregion can i force push to this PR? |
@zariiii9003 sure, go ahead. |
@danielhrisca would it be possible to stream to a file directly? |
The only way to
|
@danielhrisca The BlfWriter compresses and writes data in chunks so maybe that could be possible here too? |
setup.py
Outdated
@@ -36,6 +36,10 @@ | |||
"viewer": [ | |||
'windows-curses;platform_system=="Windows" and platform_python_implementation=="CPython"' | |||
], | |||
"mf4": [ | |||
'asammdf>=6.0.0;platform_python_implementation=="CPython" and python_version<"3.11"', | |||
'numpy;platform_python_implementation=="CPython" and python_version<"3.11"', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to remove the platform and python version requirements unless there is a good reason not to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think i added this so CI does not fail on PyPy and CPython 3.11. But there's probably a better solution for that. I admit this is ugly.
""" | ||
Iterator of CAN messages from a MF4 logging file. | ||
|
||
The MF4Reader only supports MF4 files that were recorded with python-can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a limitation of asammdf. See here
# Conflicts: # can/__init__.py # can/io/__init__.py # can/io/logger.py # can/io/player.py
@danielhrisca merged after only 3.5 years 💪 |
It's like a good wine |
I rebased #554
Closes #506