Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing vector devices #1296

Merged
merged 1 commit into from Apr 20, 2022
Merged

add missing vector devices #1296

merged 1 commit into from Apr 20, 2022

Conversation

chrisoro
Copy link
Contributor

During the 4.0.0 release, you now check the int returned by vxlapi against a local enum. The local enum is out of date.

I would strongly recommend to change this logic since it results in you having to update the code every time vector releases a new device and thus extends this enum for their vxlapi.

In the meantime, please consider releasing this as a hotfix.

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #1296 (a892530) into develop (ed6cd66) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1296      +/-   ##
===========================================
- Coverage    66.06%   66.03%   -0.04%     
===========================================
  Files           86       86              
  Lines         8915     8917       +2     
===========================================
- Hits          5890     5888       -2     
- Misses        3025     3029       +4     

@zariiii9003 zariiii9003 added this to the 4.0.1 milestone Apr 20, 2022
@zariiii9003 zariiii9003 merged commit fe18a34 into hardbyte:develop Apr 20, 2022
@felixdivo felixdivo modified the milestones: 4.0.1, 4.1.0 Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants