Add device_id parameter to PcanBus constructor #1346
Merged
+59
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new device_id parameter can be used to select a PCAN channel based on the freely programmable device ID of a PCAN USB device. This change allows for a more deterministic channel selection since the device ID does not change between restarts.
Codecov Report
@@ Coverage Diff @@
## develop #1346 +/- ##
===========================================
+ Coverage 66.01% 66.06% +0.04%
===========================================
Files 86 86
Lines 8960 8973 +13
===========================================
+ Hits 5915 5928 +13
Misses 3045 3045 |
zariiii9003
reviewed
Jul 14, 2022
|
Can you format your code with black? |
Co-authored-by: zariiii9003 <52598363+zariiii9003@users.noreply.github.com>
lumagi
force-pushed
the
feature/pcan_by_dev_id
branch
from
d0576b8
to
6de3bcf
Compare
|
@zariiii9003 Is there anything else you need me to do for the merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for constructing PCAN bus instances based on the device ID.
Before, it was only possible to select a certain bus based on the channel name (i.e.
PCAN_USBBUSx). This can be troublesome since the order of the devices is not necessarily consistent across reboots or USB reconnects. With this patch, it is possible to choose the device based on its device ID. The device ID can be freely set through the API or PCAN-View.Things to discuss before a merge: